-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files : Left panel dropdown improvement for NC 25 #38217
Files : Left panel dropdown improvement for NC 25 #38217
Conversation
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Hi @Jerome-Herbinet do you have a before - after screenshot? |
Before :before.2.webmAfter :after.2.webm |
@szaimen |
@Jerome-Herbinet I think this PR should target the stable25 branch then instead of master, no? |
Yes you are right. I'll look how to do it ; is it possible to target another branch without doing a new PR ? |
You can use the cherry-pick feature of git for this |
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Files : Left panel dropdown improvement Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
d0f6b9e
to
f66be7b
Compare
Impossible, I got this : Enumerating objects: 17, done. |
You need to create a copy branch from stable25 and then cherry pick to that one... |
…' of https://github.com/nextcloud/server into Jerome-Herbinet-left-panel-dropdown-improvement-patch-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tackling this @Jerome-Herbinet! Design feedback:
- Shouldn't this use an actual action button component on the right if the entry, also for accessibility?
- The arrow pointing to the right by default looks a bit strange. By default it should point down to indicate a dropdown. When opened, it can point up (or still pointing down is also fine).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also blocking since this needs to target thr stable25 branch
I close this PR and have created a new one on stable25 branch #38338 |
(from @Clementine46)
/!\ Testing is welcome in order to make sure it's not doing side effects elsewhere in the UI.
Checklist